Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()
От | David Fetter |
---|---|
Тема | Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() |
Дата | |
Msg-id | 20180615145709.GC11598@fetter.org обсуждение исходный текст |
Ответ на | Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() (Alexander Korotkov <a.korotkov@postgrespro.ru>) |
Ответы |
Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()
|
Список | pgsql-committers |
On Fri, Jun 15, 2018 at 05:43:15PM +0300, Alexander Korotkov wrote: > On Fri, Jun 15, 2018 at 5:25 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Alexander Korotkov <a.korotkov@postgrespro.ru> writes: > > > On Fri, Jun 15, 2018 at 4:46 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > >> Maybe I just lack caffeine, but I don't see anything especially > > >> wrong with what you wrote? > > > > > It doesn't contain something particular wrong, but it's just badly > > > formatted. As I can see, we're keeping lines in commit messages no > > > longer than 80 characters when possible. I've commit message with 158 > > > characters line for no reason. It was just because I wrote this > > > commit message with word wrapping enabled. > > > > Ah, it wrapped in my mail app so I didn't notice. > > > > FWIW, I actually try to keep commit log lines to 75 characters, because > > that's what displays nicely in "git log". > > Ok, thank you for the information. I'll also try to keep it to 75 characters. > > > Links such as Discussion: > > tags tend to run over, but there's little to be done about that as long > > as gmail insists on such ridiculously long message IDs :-( > > Agree, not much can be done unless we invent some URL shortener for > mailing lists archives. Perhaps we could acquire the short.pg domain and run it off that. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate
В списке pgsql-committers по дате отправления: