Re: pgsql: Add missing includes

On 2018-01-04 22:58:28 +0000, Peter Eisentraut wrote:
> Add missing includes
> 
> <openssl/x509.h> is necessary to look into the X509 struct, used by
> ac3ff8b1d8f98da38c53a701e6397931080a39cf.

That's not sufficient here:

/home/andres/src/postgresql/src/backend/libpq/be-secure-openssl.c: In function ‘be_tls_get_certificate_hash’:
/home/andres/src/postgresql/src/backend/libpq/be-secure-openssl.c:1269:50: error: dereferencing pointer to incomplete
type‘X509 {aka struct x509_st}’
 
  if (!OBJ_find_sigid_algs(OBJ_obj2nid(server_cert->sig_alg->algorithm),
                                                  ^~
../../../src/Makefile.global:819: recipe for target 'be-secure-openssl.o' failed

It's defined in openssl's include/internal/x509_int.h which also has the
following comment:

/* Internal X509 structures and functions: not for application use */

so this looks like a nonstarter approach that shouldn't be fixed with
additional includes.

Greetings,

Andres Freund