Re: Rewriting PL/Python's typeio code
От | Anthony Bykov |
---|---|
Тема | Re: Rewriting PL/Python's typeio code |
Дата | |
Msg-id | 20171115110823.1377.63193.pgcf@coridan.postgresql.org обсуждение исходный текст |
Ответ на | [HACKERS] Rewriting PL/Python's typeio code (Tom Lane <tgl@sss.pgh.pa.us>) |
Ответы |
Re: Rewriting PL/Python's typeio code
|
Список | pgsql-hackers |
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation: tested, passed Hello, I have checked your patch. Everything looks fine for me, but I have some doubts: 1. In file plpy_exec.c there is a typo on line 347: "... We use the result and resultin[should be here "g"?] variables... 2. In file plpy_cursorobject.c there is a non-volatile variable "elem" used in try-except construction. Is that OK? -- Anthony Bykov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company The new status of this patch is: Waiting on Author
В списке pgsql-hackers по дате отправления: