Re: [HACKERS] What's with all the fflush(stderr) calls inpg_standby.c?

On 2017-09-25 10:01:35 +0900, Michael Paquier wrote:
> On Mon, Sep 25, 2017 at 9:45 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> > On a related note, the idea of removing pg_standby altogether has been
> > proposed a few times.

Including recently by me http://archives.postgresql.org/message-id/20170913064824.rqflkadxwpboabgw%40alap3.anarazel.de

> > Apparently there are a few things that it still
> > does better than standby_mode, but nobody seems in a hurry to do
> > anything about that.  Still, I'd be against spending a lot of time
> > trying to improve a tool that has mostly outlived its usefulness - we
> > ought to be trying to enhance the in-core facilities instead.
> 
> +1.

It's also pretty crummy code that has no test coverage. I'd just remove
it.

- Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers