[HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copyingfiles >2GB.

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copyingfiles >2GB.
Дата
Msg-id 20170828130545.sdajqlpr37hmmd6a@alvherre.pgsql
обсуждение исходный текст
Ответы [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copyingfiles >2GB.
Список pgsql-hackers
Robert Haas wrote:
> pg_rewind: Fix some problems when copying files >2GB.

I just noticed that this broke pg_rewind translation, because of the
INT64_FORMAT marker in the translatable string.  The message catalog now
has this:

msgid "received chunk for file \"%s\", offset "

for this source line:
       pg_log(PG_DEBUG, "received chunk for file \"%s\", offset " INT64_FORMAT ", size %d\n",              filename,
chunkoff,chunksize);
 

I don't think that this is terribly valuable as a translatable string,
so my preferred fix would be to have a new function pg_debug() here
where the messages are *not* marked for translations.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления: