[HACKERS] Misnaming of staext_dependencies_load
От | Kyotaro HORIGUCHI |
---|---|
Тема | [HACKERS] Misnaming of staext_dependencies_load |
Дата | |
Msg-id | 20170615.140041.165731947.horiguchi.kyotaro@lab.ntt.co.jp обсуждение исходный текст |
Ответы |
Re: [HACKERS] Misnaming of staext_dependencies_load
|
Список | pgsql-hackers |
Hello. It is annoying that only staext_dependencies_load is prefixed with "staext" (two t's) among several similar names prefixed by "statext"(three t's). Should we rename it to have the same prefix? regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/backend/statistics/dependencies.c b/src/backend/statistics/dependencies.c index 793b2da..ba3b1d0 100644 --- a/src/backend/statistics/dependencies.c +++ b/src/backend/statistics/dependencies.c @@ -633,11 +633,11 @@ dependency_implies_attribute(MVDependency *dependency, AttrNumber attnum)}/* - * staext_dependencies_load + * statext_dependencies_load * Load the functional dependencies for the indicated pg_statistic_ext tuple */MVDependencies* -staext_dependencies_load(Oid mvoid) +statext_dependencies_load(Oid mvoid){ bool isnull; Datum deps; @@ -987,7 +987,7 @@ dependencies_clauselist_selectivity(PlannerInfo *root, } /* load the dependency items stored inthe statistics object */ - dependencies = staext_dependencies_load(stat->statOid); + dependencies = statext_dependencies_load(stat->statOid); /* * Apply the dependencies recursively, starting withthe widest/strongest diff --git a/src/include/statistics/statistics.h b/src/include/statistics/statistics.h index a3f0d90..58e1a62 100644 --- a/src/include/statistics/statistics.h +++ b/src/include/statistics/statistics.h @@ -78,7 +78,7 @@ typedef struct MVDependencies#define SizeOfDependencies (offsetof(MVDependencies, ndeps) + sizeof(uint32))externMVNDistinct *statext_ndistinct_load(Oid mvoid); -extern MVDependencies *staext_dependencies_load(Oid mvoid); +extern MVDependencies *statext_dependencies_load(Oid mvoid);extern void BuildRelationExtStatistics(Relation onerel, doubletotalrows, int numrows, HeapTuple *rows,
В списке pgsql-hackers по дате отправления: