Re: [HACKERS] subscription worker doesn't start immediately oneabled

At Fri, 28 Apr 2017 06:43:19 +0900, Fujii Masao <masao.fujii@gmail.com> wrote in
<CAHGQGwEq=Cei2Ti7HyYjpbJbut1GALRvFX8nUb9LDiWiX-mbNw@mail.gmail.com>
> On Thu, Apr 27, 2017 at 6:32 PM, Kyotaro HORIGUCHI
> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> > At Thu, 27 Apr 2017 00:51:03 +0900, Fujii Masao <masao.fujii@gmail.com> wrote in
<CAHGQGwEQH4V2aU=wbA4Mcc+uRsrLS2rpRONLZyB2EL=f=UNypA@mail.gmail.com>
> >> On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI
> >> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> >> > At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote in
<3d6a1bd0-08ce-301d-3336-ec9f623a315d@2ndquadrant.com>
> >> >> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote:
> >> >> > The attached patch wakes up launcher when a subscription is
> >> >> > enabled. This fails when a subscription is enabled immedaitely
> >> >> > after disabling but it won't be a matter.
> >> >>
> >> >> committed, thanks
> >> >
> >> > Thanks!
> >>
> >> This patch makes me think that CREATE SUBSCRIPTION should also wake up
> >> the launcher only when ENABLE is specified. Patch attached. Thought?
> >
> > I don't think it works as expected. Disabling of a subsciption is
> > detected by the *worker* itself then it terminates by
> > itself. Only open apply transactions can prevent the behavior.
> 
> Sorry I could not understand your point. Could you elaborate this?

Ouch! Very sorry. I read your patch reversely! I misread it as
removing "if(enabled)" from the ALTER_SUBSCRIPTION_ENABLED case.

It actually works as expected.

+1 to this from me.

regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center