Re: PATCH: Make pg_stop_backup() archive wait optional
| От | Stephen Frost |
|---|---|
| Тема | Re: PATCH: Make pg_stop_backup() archive wait optional |
| Дата | |
| Msg-id | 20170404154257.GL9812@tamriel.snowman.net обсуждение исходный текст |
| Ответ на | Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional (David Steele <david@pgmasters.net>) |
| Список | pgsql-hackers |
* David Steele (david@pgmasters.net) wrote: > On 3/22/17 4:42 PM, Peter Eisentraut wrote: > >On 3/22/17 15:14, Stephen Frost wrote: > >>>-SELECT * FROM pg_stop_backup(false); > >>>+SELECT * FROM pg_stop_backup(false [, true ]); > >>> > >>>I think that it's better to get rid of "[" and "]" from the above because > >>>IMO this should be the command example that users actually can run. > >>Using the '[' and ']' are how all of the optional arguments are > >>specified in the documentation, see things like current_setting() in our > >>existing documentation: > > > >In the synopsis, but not in concrete examples. > > Wasn't quite sure what the protocol was in this case, and figured it > was easier to subtract than to add. Forgot to close this out sooner, apologies. This has been committed now. Thanks! Stephen
В списке pgsql-hackers по дате отправления: