Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATEand DELETE

On Tue, Jan 10, 2017 at 08:31:47AM -0800, David Fetter wrote:
> On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote:
> > David Fetter wrote:
> > 
> > > +    if (query->commandType == CMD_UPDATE || query->commandType == CMD_DELETE)
> > > +    {
> > > +        /* Make sure there's something to look at. */
> > > +        Assert(query->jointree != NULL);
> > > +        if (query->jointree->quals == NULL)
> > > +            ereport(ERROR,
> > > +                    (errcode(ERRCODE_SYNTAX_ERROR),
> > > +                     errmsg("%s requires a WHERE clause when the require_where hook is enabled.",
> > > +                         query->commandType == CMD_UPDATE ? "UPDATE" : "DELETE"),
> > > +                     errhint("To %s all rows, use \"WHERE true\" or similar.",
> > > +                         query->commandType == CMD_UPDATE ? "update" : "delete")));
> > > +    }
> > 
> > Per my earlier comment, I think this should use
> > ERRCODE_S_R_E_PROHIBITED_SQL_STATEMENT_ATTEMPTED instead.
> 
> Fixed.
> 
> > I think this should say "the \"require_hook\" extension" rather than
> > use the term "hook".
> 
> Fixed.
> 
> > (There are two or three translatability rules violations in this
> > snippet,
> 
> Based on the hints in the docs docs around translation, I've
> refactored this a bit.
> 
> > but since this is an extension and those are not translatable, I
> > won't say elaborate further.)
> 
> "Not translatable," or "not currently translated?"

Oops^2.  Correct patch attached and sent to correct list. :P

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers