A bug of psql completion
От | Kyotaro HORIGUCHI |
---|---|
Тема | A bug of psql completion |
Дата | |
Msg-id | 20161128.191633.194827821.horiguchi.kyotaro@lab.ntt.co.jp обсуждение исходный текст |
Ответы |
Re: A bug of psql completion
|
Список | pgsql-hackers |
Hello. I noticed that the psql completion code for "ALTER TABLE x ALTER [COLUMN] x DROP" is wrong. It works as the following =# alter table x alter x drop <tab> [nothing suggested] =# alter table x table x alter x drop <tab> DEFAULT NOT NULL The attached patch fixes it. -- Kyotaro Horiguchi NTT Open Source Software Center diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index b556c00..6aa3f20 100644 --- a/src/bin/psql/tab-complete.c +++ b/src/bin/psql/tab-complete.c @@ -1804,7 +1804,7 @@ psql_completion(const char *text, int start, int end) COMPLETE_WITH_LIST4("PLAIN", "EXTERNAL","EXTENDED", "MAIN"); /* ALTER TABLE ALTER [COLUMN] <foo> DROP */ else if (Matches7("ALTER", "TABLE", MatchAny,"ALTER", "COLUMN", MatchAny, "DROP") || - Matches8("ALTER", "TABLE", MatchAny, "TABLE", MatchAny, "ALTER", MatchAny, "DROP")) + Matches6("ALTER", "TABLE", MatchAny, "ALTER", MatchAny, "DROP")) COMPLETE_WITH_LIST2("DEFAULT", "NOTNULL"); else if (Matches4("ALTER", "TABLE", MatchAny, "CLUSTER")) COMPLETE_WITH_CONST("ON");
В списке pgsql-hackers по дате отправления: