Re: PATCH: two slab-like memory allocators
| От | Andres Freund |
|---|---|
| Тема | Re: PATCH: two slab-like memory allocators |
| Дата | |
| Msg-id | 20161127204740.dr3swudwsbafjuof@alap3.anarazel.de обсуждение исходный текст |
| Ответ на | Re: PATCH: two slab-like memory allocators (Tomas Vondra <tomas.vondra@2ndquadrant.com>) |
| Ответы |
Re: PATCH: two slab-like memory allocators
|
| Список | pgsql-hackers |
Hi, > > +typedef struct SlabBlockData *SlabBlock; /* forward reference */ > > +typedef struct SlabChunkData *SlabChunk; > > > > Can we please not continue hiding pointers behind typedefs? It's a bad > > pattern, and that it's fairly widely used isn't a good excuse to > > introduce further usages of it. > > > > Why is it a bad pattern? It hides what is passed by reference, and what by value, and it makes it a guessing game whether you need -> or . since you don't know whether it's a pointer or the actual object. All to save a * in parameter and variable declaration?... Andres
В списке pgsql-hackers по дате отправления: