Re: [PATCH v6] GSSAPI encryption support
От | Stephen Frost |
---|---|
Тема | Re: [PATCH v6] GSSAPI encryption support |
Дата | |
Msg-id | 20160315195436.GE3127@tamriel.snowman.net обсуждение исходный текст |
Ответ на | Re: [PATCH v6] GSSAPI encryption support (Robbie Harwood <rharwood@redhat.com>) |
Ответы |
Re: [PATCH v6] GSSAPI encryption support
|
Список | pgsql-hackers |
Robbie, * Robbie Harwood (rharwood@redhat.com) wrote: > Michael Paquier <michael.paquier@gmail.com> writes: > > - maj_stat = gss_accept_sec_context( > > - &min_stat, > > + maj_stat = gss_accept_sec_context(&min_stat, > > > > This is just noise. > > You're not wrong, though I do think it makes the code more readable by > enforcing style and this is a "cleanup" commit. I'll take it out if it > bothers you. First, thanks much for working on this, I've been following along the discussions and hope to be able to help move it to commit, once it's ready. Secondly, generally, speaking, we prefer that 'cleanup' type changes (particularly whitespace-only ones) are in independent commits which are marked as just whitespace/indentation changes. We have a number of organizations which follow our code changes and it makes it more difficult on them to include whitespace/indentation changes with code changes. Thanks! Stephen
В списке pgsql-hackers по дате отправления: