Re: BUG #13594: pg_ctl.exe redirects stderr to Windows Events Log if stderr is redirected to pipe

Michael Paquier wrote:
> On Thu, Jan 7, 2016 at 6:42 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> > I looked at applying this patch, but as it turns out we don't have the
> > backpatchable version.  I don't think it's a good idea to backpatch the
> > move of the file from backend to src/port -- there's precedent for
> > copying the entire function (and assorted infrastructure) to pg_ctl
> > instead.  Would you submit a patch to do that?
>
> Yes (like restricted tokens and pg_upgrade stuff we did), but I was
> just waiting that we reach an agreement for the version of master
> before moving on with patches for back branches.

Right.

> > Here's a rebased version of what you submitted last.  I tweaked a few
> > lines here and there, nothing major.  I thought your patch is ready to
> > apply and we only need the backpatchable versions.
>
> This rebased patch looks fine for me. I am attaching as well versions
> for back-branches for 9.1~9.5. In this case it is just necessary to
> duplicate pgwin32_get_dynamic_tokeninfo and pgwin32_is_service to
> pg_ctl.c to make things work properly.

Pushed.  Obviously I didn't compile any of this, so let's see how the
buildfarm likes it.

Thanks!

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services