Re: Re: BUG #13774: upgrade from 9.1 to 9.4 'succeeds' without enough disk space

On Wed, Nov 18, 2015 at 09:42:35AM -0500, Bruce Momjian wrote:
> On Wed, Nov 18, 2015 at 09:30:45AM -0500, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Very good points.  The attached patch fixes the copy parameter and
> > > addresses the errno issue by just using errno direcdtly after the
> > > _dosmaperr call.
> >
> > You did not change the comment
> >
> >    *    Returns the text of the error message for the given error number
> >
> > even though no error number is a "given" parameter anymore.  Maybe
> > "... for the most-recently-reported error"?
>
> Good point.  I have changed it to "Returns the text of the most recent
> error".

Patch applied and backpatched through 9.1.  I used a smaller patch, same
behavior, on pre-9.4 because the removal of the getErrorText() argument
were too invasive.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Roman grave inscription                             +