On 2015-09-24 10:37:33 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Lower *_freeze_max_age minimum values.
>
> Should this patch not have also touched the per-table limits in
> reloptions.c?
Hm. I guess that'd make sense. It's not really related to the goal of
making it realistic to test multixact/clog truncation, but it's less
confusing if consistent.
> Also, I went looking for documentation about the minimum allowed
> values,
I seached for references and was surprised we don't document the limits
anywhere....
> and I found places in create_table.sgml that claim these variables can be
> set to zero. You didn't break that with this patch, but it's still wrong.
Seems to have been "broken" back in 834a6da4f7 - the old table based
approach doesn't seem to have imposed lower limits. I'm not really sure
whether making the limits consistent and updating the docs or removing
them alltogether is the better approach.
Greetings,
Andres Freund