Re: creating extension including dependencies

On 2015-09-16 05:44:22 +0200, Petr Jelinek wrote:
> On 2015-09-08 04:06, Michael Paquier wrote:
> >On Tue, Sep 8, 2015 at 10:44 AM, Michael Paquier
> ><michael.paquier@gmail.com> wrote:
> >>
> >>Attached are as well changes for the documentation that I spotted in
> >>earlier reviews but were not included in the last version sent by Petr
> >>yesterday. Feel free to discard them if you think they are not
> >>adapted, the patch attached applies on top of Petr's patch.
> >
> >And /log/ is missing in src/test/modules/extensions/.gitignore.
> >
> 
> Ah sorry, I based it on my branch which didn't contain your changes. Merged.

Please remember to update the commitfest entry...

> @@ -91,8 +92,38 @@ CREATE EXTENSION [ IF NOT EXISTS ] <replaceable class="parameter">extension_name
>          The name of the schema in which to install the extension's
>          objects, given that the extension allows its contents to be
>          relocated.  The named schema must already exist.
> -        If not specified, and the extension's control file does not specify a
> -        schema either, the current default object creation schema is used.
> +        If not specified, and the extension control file does not define
> +        <literal>schema</> either, the current default object creation
> +        schema is used.
> +       </para>

Imo still a spurious change.

Imo this is ready for committer. Will work on committing in the next few
days.

Greetings,

Andres Freund