Re: pgsql: RLS refactoring

Stephen Frost wrote:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> > Stephen Frost <sfrost@snowman.net> writes:
> >
> > It looks to me like this changed the representation of stored rules, so it
> > should have included a catversion bump.  This is particularly relevant to
> > the 9.5 branch where people already have alpha installations.
>
> I had considererd if a bump was needed and figured it wasn't.
>
> The WithCheckOption node which was changed doesn't ever end up in the
> catalog, I don't believe; certainly not in pg_policy which just stores
> the expressions which come from transformWhereClause, which haven't
> changed.

Uhm, so why is it in readfuncs.c?  If you create a view "WITH CHECK
OPTION", the pg_rewrite row says ":withCheckOptions <>".  Does that not
change with your commit?

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services