Re: AcquireRewriteLocks/acquireLocksOnSubLinks vs. rowsecurity

On 2015-08-28 08:49:24 -0400, Stephen Frost wrote:
>  
> +                /*
> +                 * get_row_security_policies just added to securityQuals and/or
> +                 * withCheckOptions, and there were SubLinks, so make sure
> +                 * we lock any relations which were added as a result.
> +                 */

Very minor comment: Strictly speaking the quals/wces haven't yet been
added to the Query, that happens only few lines down. I think it makes
sense to mention that we normally rely on the parser to acquire locks,
but that can't work here since sec quals/wces aren't visible to the
parser.

Greetings,

Andres Freund