Re: Raising our compiler requirements for 9.6

Andres Freund wrote:

> I had to split of three things: LOCKMASK, the individual lock levels and
> xl_standby_lock to be able to prohibit lock.h to be included by frontend
> code. lockdefs.h works for me, counter proposals?
> 
> There weren't any places that needed additional lock.h includes.

Ah, but that's because you cheated and didn't remove the include from
namespace.h ...

> But hashfn.c somewhat hilariously missed utils/hsearch.h ;)

hah.

> diff --git a/src/include/storage/lockdefs.h b/src/include/storage/lockdefs.h
> new file mode 100644
> index 0000000..bfbcdba
> --- /dev/null
> +++ b/src/include/storage/lockdefs.h
> @@ -0,0 +1,56 @@
> +/*-------------------------------------------------------------------------
> + *
> + * lockdefs.h
> + *       Frontend exposed parts of postgres' low level lock mechanism
> + *
> + * The split between lockdefs.h and lock.h is not very principled.

No kidding!

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services