Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

Amit Kapila wrote:
> On Sat, Jun 27, 2015 at 12:54 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> >
> > On Mon, Jun 15, 2015 at 2:52 PM, Amit Kapila
> > <amit.kapila16@gmail.com> wrote:
> > > Attached patch provides a fix as per above discussion.
> >
> > I think we should emit some LOG messages here.  When we detect the
> > file is there:
> >
> > LOG: ignoring tablespace_map file because no backup_label file exists
> >
> > If the rename fails:
> >
> > LOG: could not rename file "%s" to "%s": %m
> >
> > If it works:
> >
> > LOG: renamed file "%s" to "%s"
> 
> Added the above log messages in attached patch with small change
> such that in message, file names will be displayed with quotes as most
> of other usages of rename (failure) in that file uses quotes to display
> filenames.

Why emit two messages?  Can we reduce that to a single one?  Maybe the
first one could be errdetail or something.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services