Re: pgsql: Add pg_audit, an auditing extension

Stephen Frost wrote:

> * Fujii Masao (masao.fujii@gmail.com) wrote:

> > CREATE EXTENSION pg_audit failed with the following error message
> > when shared_preload_libraries and pg_audit.log are set to pg_audit and
> > ddl, respectively.
> >
> > =# create extension pg_audit ;
> > ERROR:  pg_event_trigger_ddl_commands() can only be called in an event
> > trigger function
> > CONTEXT:  SQL statement "SELECT UPPER(object_type), object_identity
> >   FROM pg_event_trigger_ddl_commands()"
>
> Interesting.  I'm very curious about this error and if it impacts other
> extensions which use event triggers.  I'll look into it.

Can you explain what's going on here?  It seems a bit odd to me.

> > The categories of some SQL commands are different between log_statement and
> > pg_audit. For example, REINDEX is treated as DDL in pg_audit, but not in
> > log_statement. That's confusing. We should use the same "category-mapping"
> > rule as much as possible.
>
> David, Simon and I have all considered this at different times and my
> recollection is that we all felt that it made sense as DDL because
> CLUSTER is DDL (which is actually noted in the comments).  However, you
> bring up a good point that classifying it as DDL makes it different from
> what the core system does and it'd probably be good to be consistent.
>
> The question here really is- is that the right classification for
> REINDEX to have in core?  If so, shouldn't CLUSTER have the same?

Thiking a bit about this, it seems that REINDEX and CLUSTER are not
really DDL.  They are more "maintenance commands"; they don't define
anything that wasn't defined before.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services