Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0, parser/executor stuff

On 2015-04-26 18:02:06 -0700, Peter Geoghegan wrote:
> * So far, there has been a lack of scrutiny about what the patch does
> in the rewriter (in particular, to support the EXCLUDED.* pseudo-alias
> expression) and optimizer (the whole concept of an "auxiliary"
> query/plan that share a target RTE, and later target ResultRelation).
> If someone took a close look at that, it would be most helpful.
> ruleutils.c is also modified for the benefit of EXPLAIN output. This
> all applies only to the ON CONFLICT UPDATE patch. A committer could
> push out the IGNORE patch before this was 100% firm.

I'm far from an expert on the relevant regions; but I'm starting to look
nonetheless. I have to say that on a preliminary look it looks more
complicated than it has to.

Tom, any chance you could have a look at the parse->analsys->executor
transformations?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services