Re: pg_rewind tests

Peter Eisentraut wrote:
> There are some small issues with the pg_rewind tests.

Do these tests work in VPATH builds?  I now get a failure in "make
check-world" (both with and without Michael's patch).  "make check" in
src/bin/pg_rewind dies with the output below.  If I change "./pg_rewind"
to "pg_rewind", tests pass, but I wonder if the full path to the
temp-install bindir should be used instead.

make -C ../../.. DESTDIR='/home/alvherre/Code/pgsql/build/master/src/bin/pg_rewind'/tmp_check/install install
>'/home/alvherre/Code/pgsql/build/master/src/bin/pg_rewind'/tmp_check/log/install.log2>&1
 
cd /pgsql/source/master/src/bin/pg_rewind && TESTDIR='/home/alvherre/Code/pgsql/build/master/src/bin/pg_rewind'
PATH="/home/alvherre/Code/pgsql/build/master/src/bin/pg_rewind/tmp_check/install/pgsql/install/master/bin:$PATH"
LD_LIBRARY_PATH="/home/alvherre/Code/pgsql/build/master/src/bin/pg_rewind/tmp_check/install/pgsql/install/master/lib"
top_builddir='/home/alvherre/Code/pgsql/build/master/src/bin/pg_rewind/../../..'PGPORT='655432' prove -I
/pgsql/source/master/src/test/perl/--verbose t/*.pl :: local
 
t/001_basic.pl ....... 
1..4
file not found: ./pg_rewind at RewindTest.pm line 220.
# Looks like your test exited with 2 before it could output anything.
Dubious, test returned 2 (wstat 512, 0x200)
Failed 4/4 subtests 
t/002_databases.pl ... 
1..2
file not found: ./pg_rewind at RewindTest.pm line 220.
# Looks like your test exited with 2 before it could output anything.
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/2 subtests 
t/003_extrafiles.pl .. 
1..2
file not found: ./pg_rewind at RewindTest.pm line 220.
# Looks like your test exited with 2 before it could output anything.
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/2 subtests 

Test Summary Report
-------------------
t/001_basic.pl     (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan.  You planned 4 tests
butran 0.
 
t/002_databases.pl (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan.  You planned 2 tests
butran 0.
 
t/003_extrafiles.pl (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan.  You planned 2
testsbut ran 0.
 
Files=3, Tests=0, 26 wallclock secs ( 0.02 usr  0.00 sys +  4.41 cusr  0.66 csys =  5.09 CPU)
Result: FAIL
Makefile:51: recipe for target 'check' failed
make: *** [check] Error 1


-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services