Re: vac truncation scan problems

Kyotaro HORIGUCHI wrote:
> Hi, this is a bug in the commit 0d831389749a3baaced7b984205b9894a82444b9 .
> 
> It allows vucuum freeze to be skipped and inversely lets regular
> vacuum wait for lock. The attched patch fixes it.
> 
> 
> In table_recheck_autovac, vacuum options are determined as following,
> 
>  >     tab->at_vacoptions = VACOPT_SKIPTOAST |
>  >         (dovacuum ? VACOPT_VACUUM : 0) |
>  >         (doanalyze ? VACOPT_ANALYZE : 0) |
> !>         (wraparound ? VACOPT_NOWAIT : 0);
> 
> The line prefixed by '!' looks inverted.

You're absolutely right.  My mistake.  Pushed your patch, thanks.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services