Re: POLA violation with \c service=

David Fetter wrote:
> On Fri, Feb 20, 2015 at 05:55:20PM -0300, Alvaro Herrera wrote:

> > Gave this patch a look.  In general it looks pretty good, but there is
> > one troublesome point: it duplicates two functions from libpq into psql,
> > including the URI designators.  This doesn't look very nice.
> 
> My thinking behind this was that the patch is a bug fix and intended
> to be back-patched, so I wanted to mess with as little infrastructure
> as possible.

Oh, so this is to be backpatched?  Yeah, I guess in the backbranch case
it's acceptable to duplicate some bits, but I don't think this gives us
blanket permission to do it in master.  So we need two versions of the
patch.

> > 2. export it in libpgcommon.  If we choose this option we should
> > probably rename those functions, as in the attached patch.
> 
> I'm not super attached to the names.

Me neither.  Suggestions welcome.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services