Stephen Frost wrote:
> Abhijit,
>
> * Abhijit Menon-Sen (ams@2ndQuadrant.com) wrote:
> > I'm confused and unhappy about your characterisation of the state of
> > this patch. You make it seem as though there was broad consensus about
> > the changes that were needed, and that I left the patch sitting in the
> > archives for a long time without addressing important issues.
>
> The specific issue which I was referring to there was the #ifdef's for
> the deparse branch. I thought it was pretty clear, based on the
> feedback from multiple people, that all of that really needed to be
> taken out as we don't commit code to the main repo which has such
> external dependencies.
We can remove the #ifdef lines as soon as DDL deparse gets committed, of
course. There is no external dependency here, only a dependency on a
patch that's being submitted in parallel.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services