Re: s_lock.h default definitions are rather confused

On 2015-01-10 17:58:10 -0500, Tom Lane wrote:
> Andres Freund <andres@2ndquadrant.com> writes:
> > Given you got the error above, you used gcc. Have you used non-gcc
> > compiler on hppa recently? I seem to recall you mentioning that that
> > doesn't work sanely anymore? If so, perhaps we can just remove the !gcc
> > variant?
> 
> It still compiles, modulo some old and uninteresting warnings, but linking
> the postgres executable fails with
> 
> usr/ccs/bin/ld: Unsatisfied symbols:
>    pg_compiler_barrier_impl (code)
> make[2]: *** [postgres] Error 1

Ick, that one is my failure.

> Curiously, there are no compiler warnings about "reference to undeclared
> function", which is odd because I see nothing that would declare that name
> as a function or macro for non-gcc HPPA.

Yea, that's odd.

> But in any case, the fallback logic for compiler barriers evidently
> still needs work.

Will fix (or well, try). It broke due to the atomics patch.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services