Re: bin checks taking too long.

On Tue, Dec 23, 2014 at 01:55:46PM -0500, Andrew Dunstan wrote:
> On 12/23/2014 11:11 AM, Andrew Dunstan wrote:
> >   Use of uninitialized value $ENV{"top_builddir"} in concatenation (.)
> >   or string at t/001_start_stop.pl line 17.
> >   file not found: /src/test/regress/pg_regress at
> >/home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/test/perl/TestLib.pm
> >   line 142.
> >
> >This was invoked like this:
> >
> >   cd $pgsql/src/bin && make NO_LOCALE=1 installcheck
> >
> >Note that it's a vpath build.
> >
> >
> 
> The attached patch seems to fix this.

Oops.  Your fix looks good.

> However, running installcheck also
> makes very little difference to the time. These checks still take around 100
> seconds on my machine, including around 60 for the script tests. That seems
> ridiculously long, when the whole core regression suite takes 23 seconds.

I am satisfied with the performance of the TAP suites.