Re: Small TRUNCATE glitch

Alex Shulgin wrote:

> The 2PC part requires extending bool flag to fit the trunc flag, is this
> approach sane?  Given that 2PC transaction should survive server
> restart, it's reasonable to expect it to also survive the upgrade, so I
> see no clean way of adding another bool field to the
> TwoPhasePgStatRecord struct (unless some would like to add checks on
> record length, etc.).

I don't think we need to have 2PC files survive a pg_upgrade.  It seems
perfectly okay to remove them from the new cluster at some appropriate
time, *if* they are copied from the old cluster at all (I don't think
they should be.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services