Re: Segmentation fault in pg_dumpall from master down to 9.1 and other bug introduced by RLS

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> What's bothering me is that I see this in pg_dumpall output from a 9.4
> or earlier database:
>
> ALTER ROLE postgres WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN REPLICATION NOBYPASSRLS;

Ah, yeah, good point.

> That means that if you do a pg_upgrade from a 9.4 database, your built-in
> superuser will now not have rolbypassrls set, though it does in a database
> built in any other way.  Even if that doesn't have any functional effect,
> it's a recipe for confusion IMO.  So I think that the code ought to be
> "usesuper as rolbypassrls" rather than "false as rolbypassrls" for
> back branches.
>
> The only other similar case is rolreplication, which perhaps also ought
> to read as usesuper for old branches.

Agreed.  I'll take care of both and we'll make sure the new role
attributes being added will do the same for upgrades also.
Thanks!
    Stephen