Re: pgsql: Move the backup-block logic from XLogInsert to a new file, xlogi

Heikki Linnakangas wrote:
> Move the backup-block logic from XLogInsert to a new file, xloginsert.c.
>
> xlog.c is huge, this makes it a little bit smaller, which is nice. Functions
> related to putting together the WAL record are in xloginsert.c, and the
> lower level stuff for managing WAL buffers and such are in xlog.c.
>
> Also move the definition of XLogRecord to a separate header file. This
> causes churn in the #includes of all the files that write WAL records, and
> redo routines, but it avoids pulling in xlog.h into most places.

This commit broke the WAL_DEBUG case:

/pgsql/source/brin/src/backend/access/transam/xlog.c: In function 'XLogInsertRecord':
/pgsql/source/brin/src/backend/access/transam/xlog.c:1073:4: error: 'rdt_lastnormal' undeclared (first use in this
function)
    rdt_lastnormal->next = NULL;
    ^

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services