Re: expanded mode is still broken
От | Stephen Frost |
---|---|
Тема | Re: expanded mode is still broken |
Дата | |
Msg-id | 20140912134257.GO16422@tamriel.snowman.net обсуждение исходный текст |
Ответ на | expanded mode is still broken (Pavel Stehule <pavel.stehule@gmail.com>) |
Ответы |
Re: expanded mode is still broken
|
Список | pgsql-hackers |
Pavel, * Pavel Stehule (pavel.stehule@gmail.com) wrote: > I checked HEAD and border formatting is broken I agree that 'border 3' and the ascii / unicode linestyles generates an odd looking output, however... [...] > Probably not all Sergey's fixes was applied, when I tested it (9.4 with > Sergey' fixes) it works without issues (I though) I went through all of psql-wrapped-expanded-fix-v5.patch (from CAJTaR30koAru2tucYiAZ=JjFFi8TZ0K7dhfSY-y7bsFj347zdg@mail.gmail.com) and the whole thing appears to have been applied. There aren't any regression tests with '\pset border 3' and the documentation indicates that it's only sensible for HTML (where it simply tranlates into the border=.. attribute) and latex/latex-longtable. That said, it looks like it worked in 9.3. I'm guessing there's a case somewhere which isn't handling border = 3 as identical to border = 2 after these changes. If there's a specific patch that fixes this, please share a link. I'll spend a bit of time looking at it, but I'll admit that I've not spent a lot of time in this code and it isn't exactly the most straight-forward code in our tree today.. Thanks, Stephen
В списке pgsql-hackers по дате отправления: