Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?

On Wed, Sep 10, 2014 at 08:09:30PM -0400, David Johnston wrote:
> On Wed, Sep 10, 2014 at 4:20 PM, Bruce Momjian <bruce@momjian.us> wrote:
>
>     On Tue, Sep  9, 2014 at 03:40:45PM -0400, David Johnston wrote:
>
>     > "In addition to setting global defaults or attaching" <- add a comma
>     after
>     > "defaults"
>
>     I didn't like this change as it causes too many comma phrases.
>
>     Attaches are the changes since yesterday's patch.  The full patch is at:
>
>             ftp://momjian.us/postgresql/mypatches/config.diff
>
>
>
> ​At minimum the word "setting" in that paragraph needs to be made plural. ",
> you can pass settings to <productname>PostgreSQL..."​

Oh, good point, fixed.

> ​I'm not particularly fond of the overly long preamble burying the "shell
> facilities" - and the resultant comma separating the two - but cannot think of
> anything better.  Not having the transition makes it too short and curt.  The
> proposed second comma helped to at least break it up but it too doesn't sound
> all that great.
>
> I'm good for just making the plural fix and calling it a day.

Modified patch applied to head and 9.4.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +