Re: Re: [BUGS] Re: BUG #9555: pg_dump for tables with inheritance recreates the table with the wrong order of columns

On Wed, Sep  3, 2014 at 12:07:55PM -0400, Bruce Momjian wrote:
> On Mon, Sep  1, 2014 at 04:40:11PM -0400, Bruce Momjian wrote:
> > On Mon, Sep  1, 2014 at 04:06:58PM -0400, Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > >     NOTICE:  moving and merging column "c" with inherited definition
> > > >     DETAIL:  user-specified column moved to the location of the inherited
> > > >     column
> > > 
> > > Dept of nitpicking: errdetail messages are supposed to be complete
> > > sentences, properly capitalized and punctuated.  Please re-read the
> > > style guidelines if you have forgotten them.
> > 
> > Oh, yeah;  updated patch attached.
> 
> OK, patch applied.  This will warn about reordering that happens via
> SQL, and via pg_dump restore.  Do we want to go farther and preserve
> column ordering by adding ALTER TABLE [constraint] ISLOCAL and have
> pg_dump reuse binary-upgrade mode?

OK, hearing nothing, I will consider the improved notice message as
sufficient and this item closed.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +