On 2014-08-06 15:42:08 +0530, Amit Kapila wrote:
> On Tue, Aug 5, 2014 at 9:21 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> > On Thu, Jun 5, 2014 at 4:43 AM, Amit Kapila <amit.kapila16@gmail.com>
> wrote:
> > This essentially removes BgWriterDelay, but it's still mentioned in
> BgBufferSync(). Looking further, I see that with the patch applied,
> BgBufferSync() is still present in the source code but is no longer called
> from anywhere. Please don't submit patches that render things unused
> without actually removing them; it makes it much harder to see what you've
> changed. I realize you probably left it that way for testing purposes, but
> you need to clean such things up before submitting. Likewise, if you've
> rendered GUCs or statistics counters removed, you need to rip them out, so
> that the scope of the changes you've made is clear to reviewers.
FWIW, I found this email amost unreadable because it misses quoting
signs after linebreaks in quoted content.
Greetings,
Andres Freund
-- Andres Freund http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services