Re: pg_control is missing a field for LOBLKSIZE

Bruce Momjian wrote:
> On Tue, Jun 17, 2014 at 12:28:46PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > Uh, I think pg_upgrade needs to check that they match too.
> > 
> > Possibly.  What do you think it should do when examining a pg_control
> > version that lacks the field?
> 
> Good question.  I have existing cases where fields were removed, but not
> ones that were added.  As we have no way to query the old cluster's
> value for LOBLKSIZE, I think I will just add code to compare them if
> they _both_ exist.

Can't you compare it to the historic default value?  I mean, add an
assumption that people thus far has never tweaked it.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services