Re: Re: popen and pclose redefinitions causing many warning in Windows build

On Fri, Jun  6, 2014 at 01:18:24PM -0400, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Wed, May 28, 2014 at 12:29:28PM -0400, Tom Lane wrote:
> > > Bruce Momjian <bruce@momjian.us> writes:
> > > > I think this is caused because the variable is not defined as SOCKET. 
> > > > The attached patch fixes this.  This should prevent the warning.
> > > 
> > > Surely that's just going to move the errors somewhere else.  The call
> > > site still expects the argument to be int[].
> > 
> > Ah, yes, you are right.  This is a similar problem I had with libpq
> > where PQsocket() had to return an int.
> > 
> > Attached is an updated patch which follows my previous coding of
> > checking for PGINVALID_SOCKET, and if not equal, assigns the value to an
> > integer handle.  I would also like to rename variable 's' to
> > 'listen_sock', but that is not in the patch, for clarity reasons.
> > 
> > Should this be held for 9.5?  I think it is only warning removal.  On
> > the other hand, portability is what we do during beta testing.
> 
> I think this should go in 9.4, but as you say it's only warning removal
> so there is probably little point in patching further back (this code
> dates back to 9.3.)

Agreed and applied.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +