Re: crash with assertions and WAL_DEBUG

On 2014-06-14 16:53:12 -0400, Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> > I noticed that HEAD crashes at startup with assertions disabled and
> > WAL_DEBUG turned on:
> 
> > I'm using an interim fix by excepting the startup process (see attached
> > patch), like the current code does for checkpointer, but I guess a more
> > robust solution should be sought.
> 
> Spoke too soon.  This also causes trouble when any process inserts an
> xlog record and tries to print it, of course, not just startup.

I personally think we should just remove WAL_DEBUG, but I guess I won't
convince others of that... I think for now the least bad solution is to
add a #ifndef WAL_DEBUG around that assertion.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services