Re: pg_stat directory and pg_stat_statements

On 2014-06-02 22:59:55 +0900, Fujii Masao wrote:
> On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan <pg@heroku.com> wrote:
> > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
> >> You're concerned about the scenario using pg_upgrade? I'm not sure the detail
> >> of pg_upgrade. But if it doesn't work properly, we should have gotten
> >> the trouble
> >
> > I'm not worried about pg_upgrade, because by design pg_stat_statements
> > will discard stats files that originated in earlier versions. However,
> > I don't see a need to change pg_stat_statements to serialize its
> > statistics to disk in the pg_stat directory before we branch off 9.4.
> > As you mentioned, it's harmless.
> 
> Yeah, that's an idea. OTOH, there is no *strong* reason to postpone
> the fix to 9.5. So I just feel inclined to apply the fix now...

+1 for fixing it now.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services