Re: pgsql: Fix bogus %name-prefix option syntax in all our Bison files.

On 2014-05-28 22:55:28 +0200, Andres Freund wrote:
>
> Hi,
>
> On 2014-05-28 19:42:35 +0000, Tom Lane wrote:
> > Fix bogus %name-prefix option syntax in all our Bison files.
> >
> > %name-prefix doesn't use an "=" sign according to the Bison docs, but it
> > silently accepted one anyway, until Bison 3.0.  This was originally a
> > typo of mine in commit 012abebab1bc72043f3f670bf32e91ae4ee04bd2, and we
> > seem to have slavishly copied the error into all the other grammar files.
> >
> > Per report from Vik Fearing; analysis by Peter Eisentraut.
>
> Are you sure about this? When I saw those warnings first after debian
> unstable got bison 3.0 I've read the release notes and interpreted it
> differently: By accident *only* the = syntax worked for a long time. Then
> somewhere around 2.8 they added the syntax without =. That means that <
> 2.8 versions are likely not to work anymore.

So, I looked this up again. The warnings have been added in:
commit 2062d72deb37782eb2c842e8dd1e606db5accbd1
Author: Theophile Ranquet <ranquet@lrde.epita.fr>
Date:   Thu Oct 18 18:00:51 2012 +0000

while the support for the form without = was added in
commit 02975b9aade52df362645b82a81ac2134290e221
Author: Joel E. Denny <jdenny@ces.clemson.edu>
Date:   Sat Dec 2 01:52:16 2006 +0000

According to git tag --contains the syntax without = has been added in
2.4 (not 2.8 as I'd remembered) which was released 2008-11-02. It's
warning since 3.0 which was released 2013-07-25.

It's imo not realistic to rely on bison >= 2.4, at least not in the
backbranches. Pretty damn annoying. We'll have to live with those
warnings for a couple of years.

Greetings,

Andres Freund

--
 Andres Freund                       http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services