Re: -DDISABLE_ENABLE_ASSERT

On 2014-05-23 07:20:12 -0400, Robert Haas wrote:
> On Thu, May 22, 2014 at 5:00 PM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
> > Andres Freund wrote:
> >> On 2014-05-22 16:37:35 -0400, Tom Lane wrote:
> >> > We could do that ... but I wonder if we shouldn't remove assert_enabled
> >> > altogether.  What's the use case for turning it off?  Not matching the
> >> > speed of a non-cassert build, because for instance MEMORY_CONTEXT_CHECKING
> >> > doesn't get turned off.
> >>
> >> I've used it once or twice to avoid having to recompile postgres when I
> >> wanted things not to be *that* slow (AtEOXactBuffers() I am looking at
> >> you). But I wouldn't be very sad if it'd go.
> >>
> >> Anybody against that?
> >
> > I have used it too (for a different reason IIRC), but like you I
> > wouldn't have a problem if it weren't there.
> 
> I've used it, too, although not recently.

That means you're for a (differently named) disable macro? Or is it not
recent enough that you don't care?

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services