Re: Obsolete coding in fork_process.c

On Thu, May 01, 2014 at 12:13:28PM -0400, Tom Lane wrote:
> fork_process.c quoth:
> 
>     /*
>      * Flush stdio channels just before fork, to avoid double-output problems.
>      * Ideally we'd use fflush(NULL) here, but there are still a few non-ANSI
>      * stdio libraries out there (like SunOS 4.1.x) that coredump if we do.
>      * Presently stdout and stderr are the only stdio output channels used by
>      * the postmaster, so fflush'ing them should be sufficient.
>      */
>     fflush(stdout);
>     fflush(stderr);
> 
> Is there any reason not to change this to just fflush(NULL)?  We dropped
> support for SunOS 4.1 quite some time ago ...

Modern systems have other fflush(NULL) problems:

http://www.nntp.perl.org/group/perl.perl5.porters/2013/09/msg207692.html
http://perl5.git.perl.org/metaconfig.git/blob/master:/U/perl/fflushall.U

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com