Re: Useless "Replica Identity: NOTHING" noise from psql \d

On Thu, Mar 27, 2014 at 10:02:20AM +0100, Christoph Berg wrote:
> Re: Bruce Momjian 2014-03-26 <20140326161056.GA468@momjian.us>
> > The attached patch matches your suggestion.  It is basically back to
> > what the code originally had, except it skips system tables, and shows
> > "???" for invalid values.
>
> Fwiw, "make check-world" is currently broken:

Yes, the patch was partial to just show the code changes, to get
approval.  Attached is the full patch.

I did some research of the regression database to see what was being
set:

    SELECT relreplident, relkind, nspname, count(*)
    FROM pg_class, pg_namespace
    WHERE     relkind IN ('m', 'r') AND
        relnamespace = pg_namespace.oid AND
        nspname != 'pg_catalog'
    GROUP BY relreplident, nspname, relkind
    ORDER BY 1, 2, 3;

     relreplident | relkind |      nspname       | count
    --------------+---------+--------------------+-------
     d            | m       | mvschema           |     1
     d            | m       | public             |     5
     d            | r       | information_schema |     7
     d            | r       | public             |   205
     d            | r       | testxmlschema      |     3

It seems everything is default, which would not be displayed.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +