Re: Useless "Replica Identity: NOTHING" noise from psql \d

On Mon, Mar 24, 2014 at 01:35:20PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Mon, Mar 24, 2014 at 05:06:25PM +0100, Andres Freund wrote:
> > > On 2014-03-22 23:47:57 -0400, Bruce Momjian wrote:
> > > >     test=> \d+ test
> > > >                              Table "public.test"
> > > >      Column |  Type   | Modifiers | Storage | Stats target | Description
> > > >     --------+---------+-----------+---------+--------------+-------------
> > > >      x      | integer |           | plain   |              |
> > > >     Replica Identity: full
> > > >     Has OIDs: no
> > > >
> > > > I used lower-case for the value, rather than all-caps.
> > >
> > > Why? CLUSTER, PRIMARY KEY, etc. are displayed all caps, and replica
> > > identity is similarly set via ALTER TABLE ... REPLICA IDENITY?
> >
> > Oh, good points;  I had not considered PRIMARY KEY.  Updated patch
> > attached.
>
> In the "INDEX" case, should the output mention specifically which index
> is being considered?

Ah, good idea.  Updated patch attached.  The output is now:

    test=> \d+ test
                             Table "public.test"
     Column |  Type   | Modifiers | Storage | Stats target | Description
    --------+---------+-----------+---------+--------------+-------------
     x      | integer | not null  | plain   |              |
    Indexes:
        "test_pkey" PRIMARY KEY, btree (x) REPLICA IDENTITY
        "i_test2" btree (x)
-->    Replica Identity: USING INDEX "test_pkey"
    Has OIDs: no

However, now that I look at it, it seems redundant as REPLICA IDENTITY
is already marked on the actual index.  Ideas?

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +