Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?
От | Bruce Momjian |
---|---|
Тема | Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry? |
Дата | |
Msg-id | 20140306001854.GD20275@momjian.us обсуждение исходный текст |
Ответ на | Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry? (Andres Freund <andres@2ndquadrant.com>) |
Ответы |
Re: missing RelationCloseSmgr in FreeFakeRelcacheEntry?
|
Список | pgsql-hackers |
On Tue, Nov 5, 2013 at 08:36:32PM +0100, Andres Freund wrote: > On 2013-11-04 13:48:32 +0100, Andres Freund wrote: > > What about just unowning the smgr entry with > > if (rel->rd_smgr != NULL) > > smgrsetowner(NULL, rel->rd_smgr) > > when closing the fake relcache entry? > > > > That shouldn't require any further changes than changing the comment in > > smgrsetowner() that this isn't something expected to frequently happen. > > Attached is a patch doing it like that, it required slightmy more > invasive changes than that. With the patch applied we survive replay of > a primary's make check run under valgrind without warnings. Where are we on this patch? -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + Everyone has their own god. +
В списке pgsql-hackers по дате отправления: