Re: [bug fix] pg_ctl fails with config-only directory

Поиск
Список
Период
Сортировка
От Christian Kruse
Тема Re: [bug fix] pg_ctl fails with config-only directory
Дата
Msg-id 20140130082046.GD3557@defunct.ch
обсуждение исходный текст
Ответ на Re: [bug fix] pg_ctl fails with config-only directory  ("MauMau" <maumau307@gmail.com>)
Ответы Re: [bug fix] pg_ctl fails with config-only directory
Список pgsql-hackers
Hi,

personally I really dislike constructs like you used:

#ifdef WIN32if (check_if_admin)
#endif    check_root(progname);

It is hard to read and may confuse editors. Can you rewrite it?

The rest looks fine to me.

Best regards,

-- Christian Kruse               http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services


В списке pgsql-hackers по дате отправления: