Re: Useless "Replica Identity: NOTHING" noise from psql \d

On 2013-12-14 11:27:53 -0500, Tom Lane wrote:
> In HEAD:
> 
> regression=# \d pg_depend
>    Table "pg_catalog.pg_depend"
>    Column    |  Type   | Modifiers 
> -------------+---------+-----------
>  classid     | oid     | not null
>  objid       | oid     | not null
>  objsubid    | integer | not null
>  refclassid  | oid     | not null
>  refobjid    | oid     | not null
>  refobjsubid | integer | not null
>  deptype     | "char"  | not null
> Indexes:
>     "pg_depend_depender_index" btree (classid, objid, objsubid)
>     "pg_depend_reference_index" btree (refclassid, refobjid, refobjsubid)
> Replica Identity: NOTHING
> 
> Where did that last line come from, and who thinks it's so important
> that it should appear by default?  It seems absolutely content-free
> even if I were using whatever feature it refers to, since it is
> (I presume) the default state.

Hm. Yes, that's slightly inellegant. It's shown because it's not
actually the normal default normal tables. Just for system tables. Maybe
we should just set it to default (in pg_class) for system tables as
well, and just change it in the relcache.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services