Re: libpgport vs libpgcommon

Peter Eisentraut wrote:
> On 10/16/13 10:10 PM, Noah Misch wrote:
> > dirmod.c perhaps deserves a
> > split into libpgcommon parts (e.g. pgfnames()) and libpgport parts
> > (e.g. pgrename()).
> 
> I have also come to this realization.  I propose to move pgfnames to
> src/common/pgfnames.c.

Please have a look at my patch at
20130827215416.GF4933@eldon.alvh.no-ip.org particularly the checkdir.c
file.  Perhaps we'd like to put both these routines (which are related
to directories) in a single file (directory.c?).  In that case I would
suggest putting your new routine in that file, and we'd add the checkdir
stuff in there eventually.

I don't necessarily object to pgfnames.c in any case, if that's thought
to be cleaner.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services