Re: relscan_details.h

On Tue, Oct 01, 2013 at 10:12:05PM -0400, Bruce Momjian wrote:
> If we had not made massive cleanup changes years ago, our code would not
> be as good as it is today.  By avoiding cleanup to reduce the burden on
> people who use our code, we are positioning our code on a slow decline
> in clarity.
> 
> What I don't want to do is get into a mode where every code cleanup has
> to be verified that it isn't going to excessively burden outside code
> users.  Cleanup is hard enough, and adding another check to that process
> makes cleanup even less likely.

I don't disagree with that, but I would describe the proposal as a mild
dirty-up for the sake of build performance, not a cleanup.

-- 
Noah Misch
EnterpriseDB                                 http://www.enterprisedb.com