Re: Strange hanging bug in a simple milter

On 2013-09-13 15:03:31 -0400, Stephen Frost wrote:
> * Andres Freund (andres@2ndquadrant.com) wrote:
> > It seems slightly cleaner to just move the pqsecure_destroy(); to the
> > end of that function, based on a boolean. But if you think otherwise, I
> > won't protest...
> 
> Hmm, agreed; I had originally been concerned that the SIGPIPE madness
> needed to be around the pqsecure_destroy() call, but I can't see why
> that would be.
> 
> I've run through a few times w/ the attached and haven't seen the
> deadlock.  Will continue testing, of course.

That patch looks wrong to me. Note that the if (conn->ssl) branch resets
conn->ssl to NULL.

Greetings,

Andres Freund

-- Andres Freund                       http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training &
Services